Re: [PATCH v13 net-next 13/15] net: mvpp2: add PPv23 RX FIFO flow control

[Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx>]

On Thu, Feb 11, 2021 at 12:49:00PM +0200, stefanc@xxxxxxxxxxx wrote:
> +/* Configure Rx FIFO Flow control thresholds */
> +void mvpp23_rx_fifo_fc_en(struct mvpp2 *priv, int port, bool en)
> +{
> +	int val;

	u32 ?

> +
> +	val = mvpp2_read(priv, MVPP2_RX_FC_REG(port));
> +
> +	if (en)
> +		val |= MVPP2_RX_FC_EN;
> +	else
> +		val &= ~MVPP2_RX_FC_EN;
> +
> +	mvpp2_write(priv, MVPP2_RX_FC_REG(port), val);

	if (en)
		val = MVPP2_RX_FC_EN;
	else
		val = 0;

	mvpp2_modify(priv + MVPP2_RX_FC_REG(port), MVPP2_RX_FC_EN, val);

?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!