Re: [PATCH] pinctrl: imx: imx8mm: fix pad offset of SD1_DATA0 pin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/11/21 11:17 AM, Frieder Schrempf wrote:
On 11.02.21 10:54, Claudius Heine wrote:
There is a 0 missing in the pad register offset. This patch adds it.

Signed-off-by: Claudius Heine <ch@xxxxxxx>

I think this should rather be prefixed by "arm64: dts: imx8mm:" as this is no change in the pinctrl driver, but only in the devicetree.

And I guess this deserves a "Fixes" and "Cc: stable" tag, so:

Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm")
Cc: stable@xxxxxxxxxxxxxxx
Reviewed-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>

Indeed.

But since this isn't the first such fix, I wonder whether it wouldn't be a good idea to regenerate those pinctrl tables and see whether there are any other such issues in them. I wonder, is there some sort of register and bit list in machine-parseable form for the MX8M ?



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux