Le mardi 09 février 2021 à 10:13 -0600, Rob Herring a écrit : > On Thu, Jan 21, 2021 at 06:43:47PM +0100, Vincent Knecht wrote: > > This adds dts bindings for the mstar msg26xx touchscreen. > > > > Signed-off-by: Vincent Knecht <vincent.knecht@xxxxxxxxxx> > > --- > > Changed in v3: > > - added `touchscreen-size-x: true` and `touchscreen-size-y: true` properties > > Changed in v2: > > - changed M-Star to MStar in title line > > - changed reset gpio to active-low in example section > > --- > > .../input/touchscreen/mstar,msg26xx.yaml | 69 +++++++++++++++++++ > > 1 file changed, 69 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/mstar,msg26xx.yaml > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/mstar,msg26xx.yaml > > b/Documentation/devicetree/bindings/input/touchscreen/mstar,msg26xx.yaml > > new file mode 100644 > > index 000000000000..5d26a1008bf1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/touchscreen/mstar,msg26xx.yaml > > @@ -0,0 +1,69 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/input/touchscreen/mstar,msg26xx.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MStar msg26xx touchscreen controller Bindings > > + > > +maintainers: > > + - Vincent Knecht <vincent.knecht@xxxxxxxxxx> > > + > > +allOf: > > + - $ref: touchscreen.yaml# > > + > > +properties: > > + compatible: > > + const: mstar,msg26xx > > Don't use wildcards in compatible strings. Thank you for the input... Let's say I set it to "mstar,msg2638", is it better to rename the driver file and functions too ? According to downstream source file naming, msg2638 is the model I have and test this driver with. There's a possibility this driver works as-is or with minor mods for msg2633 too, and a more remote one for msg21xx and msg22xx...
