> -----Original Message----- > From: Lars-Peter Clausen [mailto:lars@xxxxxxxxxx] > Sent: Monday, February 8, 2021 5:00 AM > To: Jonathan Cameron <jic23@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx > Cc: Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>; Song Bao Hua (Barry Song) > <song.bao.hua@xxxxxxxxxxxxx>; robh+dt@xxxxxxxxxx; Jonathan Cameron > <jonathan.cameron@xxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 21/24] dt-bindings:iio:cdc:adi,ad7150 binding doc > > On 2/7/21 4:46 PM, Jonathan Cameron wrote: > > +required: > > + - compatible > > + - reg > > Is vdd-supply really optional the way it is implemented in the driver? > > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cdc@48 { > > + compatible = "adi,ad7150"; > > + reg = <0x48>; > > + interrupts = <25 2>, <26 2>; One question, here we have two interrupts, but the driver is reading one interrupt only, do we need to call of_irq_get(dev, index) or of_irq_get_byname()? > > I wonder if we should use the symbolic constants for the IRQ type to > make the example more clear. E.g. > > interrupts = <25 IRQ_TYPE_EDGE_FALLING>, ... > > > + interrupt-parent = <&gpio>; > > + }; > > + }; > > +... > Thanks Barry
