Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

>vreg_l14a_1p88: ldo14 {
>+			regulator-min-microvolt = <1800000>;
>+			regulator-max-microvolt = <1800000>;

Should probably be renamed to vreg_l14a_1p8 then.


>+	ports {
>+		port@1 {
>+			endpoint {
>+				remote-endpoint = <&tianma_nt36672a_in_0>;
>+				data-lanes = <0 1 2 3>;
>+			};
>+		};
>+	};

The endpoint has a label, you can simply use &dsi0_out {};.

>+		vddpos-supply = <&lab>;
>+		vddneg-supply = <&ibb>;

With Angelo's latest series [1] merged in, I reckon you should explicitly configure lab/ibb (like in [2]),
as wrong settings (which CAN BE SET BY THE BOOTLOADER in some instances!!) can lead to hardware damage.



Konrad

[1] https://lore.kernel.org/linux-arm-msm/20210119174421.226541-1-angelogioacchino.delregno@xxxxxxxxxxxxxx/
[2] https://github.com/SoMainline/linux/commit/4f4853b2e252b5f9d03e90119110aac80258fc53



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux