On 27/01/2021 18:31, Thierry Reding wrote: > On Wed, Jan 27, 2021 at 05:52:50PM +0000, Jon Hunter wrote: >> There are two versions of the Jetson Xavier NX system-on-module; one >> with a micro SD-card slot and one with an eMMC. Currently, only the >> system-on-module with the micro SD-card slot is supported and so add >> necessary device-tree changes to add support for the eMMC version. >> >> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx> >> --- >> arch/arm64/boot/dts/nvidia/Makefile | 1 + >> .../nvidia/tegra194-p3509-0000+p3668-0000.dts | 351 +----------------- >> .../nvidia/tegra194-p3509-0000+p3668-0001.dts | 10 + >> .../boot/dts/nvidia/tegra194-p3509-0000.dtsi | 351 ++++++++++++++++++ >> .../boot/dts/nvidia/tegra194-p3668-0000.dtsi | 282 +------------- >> .../boot/dts/nvidia/tegra194-p3668-0001.dtsi | 19 + >> .../arm64/boot/dts/nvidia/tegra194-p3668.dtsi | 284 ++++++++++++++ >> 7 files changed, 669 insertions(+), 629 deletions(-) >> create mode 100644 arch/arm64/boot/dts/nvidia/tegra194-p3509-0000+p3668-0001.dts >> create mode 100644 arch/arm64/boot/dts/nvidia/tegra194-p3509-0000.dtsi >> create mode 100644 arch/arm64/boot/dts/nvidia/tegra194-p3668-0001.dtsi >> create mode 100644 arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi > > This looks good, although I must say this is difficult to review. Maybe > it would help if this was split into two patches where first the files > are split for tegra194-p3509-0000+p3668-0000 and the second patch adds > only the files for the new SKU. Yes, OK I will do that. I must admit the diff is not very clear. Jon -- nvpublic
