Hi Rob, thanks for the comments, I'll fix the issue on the next serial.
Thanks,
Xin
On Mon, Jan 25, 2021 at 09:41:43AM -0600, Rob Herring wrote:
> On Mon, Jan 25, 2021 at 07:12:21PM +0800, Xin Ji wrote:
> > Add 'bus-type' and 'data-lanes' define for port0, add HDCP support
> > flag and DP tx lane0 and lane1 swing register array define.
> >
> > Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx>
> > ---
> > .../bindings/display/bridge/analogix,anx7625.yaml | 57 ++++++++++++++++++++--
> > 1 file changed, 54 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index 60585a4..3b1cbe0 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -34,23 +34,69 @@ properties:
> > description: used for reset chip control, RESET_N pin B7.
> > maxItems: 1
> >
> > + analogix,lane0-swing:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + description:
> > + an array of swing register setting for DP tx lane0 PHY, please don't
> > + add this property, or contact vendor.
> > +
> > + analogix,lane1-swing:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + description:
> > + an array of swing register setting for DP tx lane1 PHY, please don't
> > + add this property, or contact vendor.
> > +
> > + analogix,hdcp-support:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description: indicate the DP tx HDCP support or not.
>
> Sounds like a boolean.
OK, I'll change it to boolean.
>
> > +
> > ports:
> > type: object
> > + additionalProperties: false
> >
> > properties:
> > port@0:
> > type: object
> > description:
> > - Video port for MIPI DSI input.
> > + Video port for MIPI input.
>
> You're going to need to rebase this one drm-misc-next which uses the
> graph schema now.
OK, I'll rebase it.
>
> > +
> > + properties:
> > + endpoint:
> > + type: object
> > + additionalProperties: false
> > +
> > + # Properties described in
> > + # Documentation/devicetree/bindings/media/video-interfaces.txt
> > + properties:
> > + remote-endpoint: true
> > + bus-type: true
> > + data-lanes: true
> > +
> > + required:
> > + - remote-endpoint
> > +
> > + required:
> > + - endpoint
> >
> > port@1:
> > type: object
> > description:
> > Video port for panel or connector.
> >
> > + properties:
> > + endpoint:
> > + type: object
> > + additionalProperties: false
> > +
> > + required:
> > + - remote-endpoint
> > +
> > + required:
> > + - endpoint
> > +
> > required:
> > - - port@0
> > - - port@1
> > + - port@0
> > + - port@1
> >
> > required:
> > - compatible
> > @@ -73,6 +119,10 @@ examples:
> > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> >
> > + analogix,lane0-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
> > + analogix,lane1-swing = <0x14 0x54 0x64 0x74 0x29 0x7b 0x77 0x5b>;
> > + analogix,hdcp-support = <0>;
> > +
> > ports {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > @@ -81,6 +131,7 @@ examples:
> > reg = <0>;
> > anx7625_in: endpoint {
> > remote-endpoint = <&mipi_dsi>;
> > + bus-type = <5>;
> > };
> > };
> >
> > --
> > 2.7.4
> >
