On Fri, Jan 22, 2021 at 09:55:56AM +0000, ChiaWei Wang wrote: > Hi Corey, > > Could you help to review this patch to kcs_bmc_aspeed.c? > It mainly fixes the register layout/offsets of Aspeed LPC controller. I am not really qualified to review this. It looks ok from a structural and style point of view, but that's all I can tell. So I'm ok with it. Acked-by: Corey Minyard <cminyard@xxxxxxxxxx> > > Thanks, > Chiawei > > > -----Original Message----- > > From: Andrew Jeffery <andrew@xxxxxxxx> > > Sent: Wednesday, January 20, 2021 1:03 PM > > Subject: Re: [PATCH v5 3/5] ipmi: kcs: aspeed: Adapt to new LPC DTS layout > > > > > > > > On Thu, 14 Jan 2021, at 23:46, Chia-Wei, Wang wrote: > > > Add check against LPC device v2 compatible string to ensure that the > > > fixed device tree layout is adopted. > > > The LPC register offsets are also fixed accordingly. > > > > > > Signed-off-by: Chia-Wei, Wang <chiawei_wang@xxxxxxxxxxxxxx> > > > Acked-by: Haiyue Wang <haiyue.wang@xxxxxxxxxxxxxxx> > > > > Reviewed-by: Andrew Jeffery <andrew@xxxxxxxx> > > Thanks for the review.
