On Tue, Jan 19, 2021 at 4:20 AM DENG Qingfang <dqfext@xxxxxxxxx> wrote: > On Mon, Jan 18, 2021 at 10:55 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > > > So for offset 0..14 this becomes bits > > 0, 1, 2, 4, 5, 6, 8, 9, 10, 12 ... 18 > > > > What is the logic in this and is it what you intend? > > Yes. Bit 0..2 are phy 0's LED 0..2, bit 4..6 are phy 1's LED 0..2, etc. OK add a comment and explain how the bits relate to each PHY and how the lines are arranged per-phy so it is crystal clear for people reading the driver. Thanks! Linus Walleij
