Hi Rob,
Le jeu. 21 janv. 2021 à 10:01, Rob Herring <robh@xxxxxxxxxx> a écrit :
On Wed, 20 Jan 2021 11:59:44 +0000, Paul Cercueil wrote:
Add the ingenic,jz4760-phy and ingenic,jz4760b-phy compatible
strings,
and make the ingenic,jz4770-phy compatible string require
ingenic,jz4760-phy as a fallback, since both work the same, and the
JZ4760 SoC is older.
Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
---
.../bindings/phy/ingenic,phy-usb.yaml | 22
++++++++++++-------
1 file changed, 14 insertions(+), 8 deletions(-)
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml:20:9:
[warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml:27:9:
[warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml:28:11:
[warning] wrong indentation: expected 12 but found 10 (indentation)
I can reproduce, however the indentation in the DTS looks awfully
correct to me. Could you tell me what it is doing wrong?
Cheers,
-Paul
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/ingenic,cgu.example.dt.yaml:
clock-controller@10000000: usb-phy@3c:compatible: 'oneOf' conditional
failed, one must be fixed:
['ingenic,jz4770-phy'] is too short
'ingenic,jz4770-phy' is not one of ['ingenic,jz4760-phy',
'ingenic,jz4775-phy', 'ingenic,jz4780-phy', 'ingenic,x1000-phy',
'ingenic,x1830-phy', 'ingenic,x2000-phy']
From schema:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/ingenic,cgu.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/ingenic,cgu.example.dt.yaml:
usb-phy@3c: compatible: 'oneOf' conditional failed, one must be fixed:
['ingenic,jz4770-phy'] is too short
'ingenic,jz4770-phy' is not one of ['ingenic,jz4760-phy',
'ingenic,jz4775-phy', 'ingenic,jz4780-phy', 'ingenic,x1000-phy',
'ingenic,x1830-phy', 'ingenic,x2000-phy']
From schema:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml
See https://patchwork.ozlabs.org/patch/1429154
This check can fail if there are any dependencies. The base for a
patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up
to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
