On Thu, Jan 21, 2021 at 10:41:36PM +0200, Andy Shevchenko wrote: > On Thu, Jan 21, 2021 at 01:52:06PM -0600, Bjorn Helgaas wrote: > > On Fri, Jan 22, 2021 at 08:56:10AM +0530, srikanth.thokala@xxxxxxxxx wrote: > > <checks MAINTAINERS> ... yep, all previous entries are in alphabetical > > order. This new one just got dropped at the end. > > > > I feel like a broken record, but please, please, take a look at the > > surrounding code/text/whatever, and MAKE YOUR NEW STUFF MATCH THE > > EXISTING STYLE. We want the whole thing to be reasonably consistent > > so readers can make sense of it without being confused by the > > idiosyncrasies of every contributor. > > I guess even checkpatch.pl should complain about this these days. Maybe so. But paying attention to the surrounding content can prevent a whole host of style problems that checkpatch.pl can't catch. We call these changes "patches," but that's an unfortunate term. It suggests a band-aid, which is something very obvious. If a Linux change is done well, a reader should not be able to tell that it was added later. It should look like it was always there from the very beginning. Bjorn
