On 1/21/21 9:37 AM, Nishanth Menon wrote: > On 13:48-20210114, Suman Anna wrote: > [...] > >> + >> + icssg1_intc: interrupt-controller@20000 { >> + compatible = "ti,icssg-intc"; >> + reg = <0x20000 0x2000>; >> + interrupt-controller; >> + #interrupt-cells = <3>; >> + interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>; >> + interrupt-names = "host_intr0", "host_intr1", >> + "host_intr2", "host_intr3", >> + "host_intr4", "host_intr5", >> + "host_intr6", "host_intr7"; > > > Could you look at https://pastebin.ubuntu.com/p/rbZrv3sDFk/ > Yes, I am aware of these, and I have already noted it in my cover-letter. "Note that the interrupt nodes will generate a warning about missing '#address-cells' when compiled using W=2, but adding that currently fails the dtbs_check, so going with the dt binding compliance." I have submitted two incremental patches, one against the binding [1] and another against dts [2]. regards Suman [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115205819.19426-1-s-anna@xxxxxx/ [2] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115210625.20427-1-s-anna@xxxxxx/