Hi,
On 12/7/20 10:32 AM, Michal Simek wrote:
>
>
> On 06. 12. 20 23:38, Laurent Pinchart wrote:
>> Hi Michal,
>>
>> Thank you for the patch.
>>
>> On Wed, Dec 02, 2020 at 03:06:03PM +0100, Michal Simek wrote:
>>> Enable reset controller for several IPs.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
>>> ---
>>>
>>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 29 ++++++++++++++++++++++++++
>>> 1 file changed, 29 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> index 68923fbd0e89..4fa820f78d76 100644
>>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> @@ -187,6 +187,11 @@ zynqmp_pcap: pcap {
>>> xlnx_aes: zynqmp-aes {
>>> compatible = "xlnx,zynqmp-aes";
>>> };
>>> +
>>> + zynqmp_reset: reset-controller {
>>> + compatible = "xlnx,zynqmp-reset";
>>> + #reset-cells = <1>;
>>> + };
>>> };
>>> };
>>>
>>> @@ -466,6 +471,8 @@ gem0: ethernet@ff0b0000 {
>>> #address-cells = <1>;
>>> #size-cells = <0>;
>>> power-domains = <&zynqmp_firmware PD_ETH_0>;
>>> + resets = <&zynqmp_reset ZYNQMP_RESET_GEM0>;
>>> + reset-names = "gem0_rst";
>>
>> I don't see any of the reset-names used in this patch defined in DT
>> bindings (or used in drivers). For all devices but the USB controllers
>> it seems they can be dropped. For the USB controllers, the bindings need
>> to be updated first.
>
> Let me double check it. IIRC if there is just one there is likely no
> need to list the name but if there are more then one names should be
> also there. But you are right it should be the part of dt binding.
I will skip this patch.
Thanks,
Michal
