Hi Mark, This patch series finish addressing support for Hikey 970 SPMI controller, PMIC and regulators. I removed some unrelated DT patches from this series, plus the Hikey 970 PHY USB3 code from it, in order to avoid mixing different stuff on this series[1]. [1] Those unrelated patches were submitted last week on separate series. The entire patchset is on this branch: https://git.linuxtv.org/mchehab/experimental.git/log/?h=devel/destage-usb In order to make easier for review, this series was generated with --no-merges. So, you don't need to take a look at the staging patches, as the entire code will be there on patches 9-11. Patches 12 and 13 on this series will require that the other patch series to get merged first. It probably makes sense to be merged via DT tree. I opted to add them here just because, on the last submission, you asked to see the DT patches. On this version 2, I addressed almost all issues you pointed during your review: - this driver's probe routine is very similar to the one at the non-SPMI variant of Hisilicon 6421; - The register/voltage data were moved from DT into the driver itself; - It doesn't have anymore any static data; - All debug messages got removed; - Addressed a few be32 warnings from sparse. Regards, Mauro Mauro Carvalho Chehab (13): staging: hikey9xx: hisilicon,hisi-spmi-controller.yaml fix bindings staging: hikey9xx: hisi-spmi-controller: clean sparse warnings staging: hikey9xx: hi6421v600-regulator: do some cleanups staging: hikey9xx: hi6421v600-regulator: move LDO config from DT staging: hikey9xx: hi6421v600-regulator: cleanup debug msgs staging: hikey9xx: hisilicon,hi6421-spmi-pmic.yaml: simplify props staging: hikey970: get rid of an static data staging: hikey9xx: hi6421v600-regulator: do some cleanups spmi: hi6421-spmi-pmic: move driver from staging mfd: hi6421-spmi-pmic: move driver from staging regulator: hi6421v600-regulator: move it from staging dts: hisilicon: add support for USB3 on Hikey 970 dts: hisilicon: add support for the PMIC found on Hikey 970 .../mfd/hisilicon,hi6421-spmi-pmic.yaml | 135 +++++ .../spmi/hisilicon,hisi-spmi-controller.yaml | 75 +++ MAINTAINERS | 15 +- .../boot/dts/hisilicon/hi3670-hikey970.dts | 124 ++++- arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 58 +++ .../boot/dts/hisilicon/hikey970-pmic.dtsi | 87 ++++ drivers/mfd/Kconfig | 15 + drivers/mfd/Makefile | 1 + drivers/mfd/hi6421-spmi-pmic.c | 342 +++++++++++++ drivers/regulator/Kconfig | 8 + drivers/regulator/Makefile | 1 + drivers/regulator/hi6421v600-regulator.c | 347 +++++++++++++ drivers/spmi/Kconfig | 9 + drivers/spmi/Makefile | 1 + drivers/spmi/hisi-spmi-controller.c | 358 +++++++++++++ drivers/staging/Kconfig | 2 - drivers/staging/Makefile | 1 - drivers/staging/hikey9xx/Kconfig | 38 -- drivers/staging/hikey9xx/Makefile | 5 - drivers/staging/hikey9xx/TODO | 5 - drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 342 ------------- .../staging/hikey9xx/hi6421v600-regulator.c | 478 ------------------ .../staging/hikey9xx/hisi-spmi-controller.c | 358 ------------- .../hikey9xx/hisilicon,hi6421-spmi-pmic.yaml | 159 ------ .../hisilicon,hisi-spmi-controller.yaml | 62 --- 25 files changed, 1554 insertions(+), 1472 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml create mode 100644 Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml create mode 100644 arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi create mode 100644 drivers/mfd/hi6421-spmi-pmic.c create mode 100644 drivers/regulator/hi6421v600-regulator.c create mode 100644 drivers/spmi/hisi-spmi-controller.c delete mode 100644 drivers/staging/hikey9xx/Kconfig delete mode 100644 drivers/staging/hikey9xx/Makefile delete mode 100644 drivers/staging/hikey9xx/TODO delete mode 100644 drivers/staging/hikey9xx/hi6421-spmi-pmic.c delete mode 100644 drivers/staging/hikey9xx/hi6421v600-regulator.c delete mode 100644 drivers/staging/hikey9xx/hisi-spmi-controller.c delete mode 100644 drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml delete mode 100644 drivers/staging/hikey9xx/hisilicon,hisi-spmi-controller.yaml -- 2.29.2