On Thu, Jan 14, 2021 at 6:38 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > Quoting Philip Chen (2021-01-14 18:30:30) > > Add a new property `function-row-physmap` to the > > device tree for the custom keyboard top row design. > > > > The property describes the rows/columns of the top row keys > > from left to right. > > > > Signed-off-by: Philip Chen <philipchen@xxxxxxxxxxxx> > > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > > One nit below. > > > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > index 8e50c14a9d778..a742b0777ee6d 100644 > > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml > > @@ -43,6 +54,18 @@ examples: > > keypad,num-rows = <8>; > > keypad,num-columns = <13>; > > google,needs-ghost-filter; > > + function-row-physmap = < > > + 0x00020000 /* T1 */ > > + 0x03020000 /* T2 */ > > + 0x02020000 /* T3 */ > > + 0x01020000 /* T4 */ > > + 0x03040000 /* T5 */ > > + 0x02040000 /* T6 */ > > + 0x01040000 /* T7 */ > > + 0x02090000 /* T8 */ > > + 0x01090000 /* T9 */ > > + 0x00040000 /* T10 */ > > Can we include the header file for MATRIX_KEY so we can use the macro > here? Sure.
