Hi Vinod/Rob, This series moves the Hikey 970 USB PHY driver out of staging. The 3 initial patches address the issues pointed by Vinod: patch 1 change the logic to use GENMASK and FIELD_GET/FIELD_PREP macros. It also places all hexadecimal values in lowercase; patch 2 add a delay inside the retry logic; patch 3 changes a function to return a boolean. The 4th patch is actually identical to the patch I sent previously: it just moves the driver to drivers/phy and add a blank line at the yaml driver: rename drivers/staging/hikey9xx/phy-hi3670-usb3.yaml => Documentation/devicetree/bindings/phy/hisilicon,hi3670-usb3.yaml (99%) rename drivers/{staging/hikey9xx => phy/hisilicon}/phy-hi3670-usb3.c (100%) In order to make this series easier to review, I'm submitting it with --no-merges. This way, you can check the driver and DT bindings as a hole while reviewing the last patch. - v3: - no changes on patches 1-2 nor at phy-hi3670-usb3.c; - yaml renamed to: hisilicon,hi3670-usb3.yaml - Added a blank line after maintainers at hisilicon,hi3670-usb3.yaml Mauro Carvalho Chehab (4): staging: hikey9xx: phy-hi3670-usb3.c: use bitfield macros staging: hikey9xx: phy-hi3670-usb3.c: adjust retry logic staging: hikey9xx: phy-hi3670-usb3.c: hi3670_is_abbclk_seleted() returns bool phy: phy-hi3670-usb3: move driver from staging into phy .../bindings/phy/phy-hi3670-usb3.yaml | 72 ++ MAINTAINERS | 9 +- drivers/phy/hisilicon/Kconfig | 10 + drivers/phy/hisilicon/Makefile | 1 + drivers/phy/hisilicon/phy-hi3670-usb3.c | 668 +++++++++++++++++ drivers/staging/hikey9xx/Kconfig | 11 - drivers/staging/hikey9xx/Makefile | 2 - drivers/staging/hikey9xx/phy-hi3670-usb3.c | 671 ------------------ drivers/staging/hikey9xx/phy-hi3670-usb3.yaml | 72 -- 9 files changed, 759 insertions(+), 757 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3670-usb3.yaml create mode 100644 drivers/phy/hisilicon/phy-hi3670-usb3.c delete mode 100644 drivers/staging/hikey9xx/phy-hi3670-usb3.c delete mode 100644 drivers/staging/hikey9xx/phy-hi3670-usb3.yaml -- 2.29.2