On 1/14/21 10:35 AM, George McCollister wrote: >> Nothing frees up the successfully allocated p->mib_data[] in case of >> errors so you would be leaking here. > > In case of an error probe will end up returning an error and the > memory will be free'd since it was allocated with a devm_ function, > won't it? Sorry completely missed that xrs700x_alloc_port_mib() used a devm_kzalloc(), this is fine. -- Florian
