Re: [PATCH 13/18] ARM: dts: Use simple-pm-bus for genpd for am3 l4_wkup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tony,

On Mon, Oct 26, 2020 at 1:57 PM Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> We can now enable simple-pm-bus to use genpd.
>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>

Thanks for your patch, which is now commit 5a230524f87926f2 ("ARM:
dts: Use simple-pm-bus for genpd for am3 l4_wkup") in v5.11-rc1.

I have bisected a boot failure on BeagleBone Black to this commit.
Reverting this commit on top of a v5.11-rc3-based tree does not help.

With "earlycon keep_bootcon", I do get some output, the last line is

    l4-wkup-clkctrl:00d4:0: failed to disable

I have attached the kernel output of the previous (good) commit,
and the failing one.

Do you have a clue?
Thanks!

> --- a/arch/arm/boot/dts/am33xx-l4.dtsi
> +++ b/arch/arm/boot/dts/am33xx-l4.dtsi
> @@ -1,5 +1,8 @@
>  &l4_wkup {                                             /* 0x44c00000 */
> -       compatible = "ti,am33xx-l4-wkup", "simple-bus";
> +       compatible = "ti,am33xx-l4-wkup", "simple-pm-bus";
> +       power-domains = <&prm_wkup>;
> +       clocks = <&l4_wkup_clkctrl AM3_L4_WKUP_L4_WKUP_CLKCTRL 0>;
> +       clock-names = "fck";
>         reg = <0x44c00000 0x800>,
>               <0x44c00800 0x800>,
>               <0x44c01000 0x400>,
> @@ -12,7 +15,7 @@ &l4_wkup {                                            /* 0x44c00000 */
>                  <0x00200000 0x44e00000 0x100000>;      /* segment 2 */
>
>         segment@0 {                                     /* 0x44c00000 */
> -               compatible = "simple-bus";
> +               compatible = "simple-pm-bus";
>                 #address-cells = <1>;
>                 #size-cells = <1>;
>                 ranges = <0x00000000 0x00000000 0x000800>,      /* ap 0 */
> @@ -22,7 +25,7 @@ segment@0 {                                   /* 0x44c00000 */
>         };
>
>         segment@100000 {                                        /* 0x44d00000 */
> -               compatible = "simple-bus";
> +               compatible = "simple-pm-bus";
>                 #address-cells = <1>;
>                 #size-cells = <1>;
>                 ranges = <0x00000000 0x00100000 0x004000>,      /* ap 4 */
> @@ -54,7 +57,7 @@ wkup_m3: cpu@0 {
>         };
>
>         segment@200000 {                                        /* 0x44e00000 */
> -               compatible = "simple-bus";
> +               compatible = "simple-pm-bus";
>                 #address-cells = <1>;
>                 #size-cells = <1>;
>                 ranges = <0x00000000 0x00200000 0x002000>,      /* ap 8 */

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Attachment: dmesg-5.10.0-rc1-boneblack-00027-gb0625afe3052
Description: Binary data

Attachment: dmesg-5.10.0-rc1-boneblack-00028-g5a230524f879
Description: Binary data


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux