On Mon, Dec 07, 2020 at 01:30:18PM +0100, Jens Wiklander wrote:
> Hi Sudeep,
>
> Some comments below.
>
> On Fri, Dec 04, 2020 at 12:11:36PM +0000, Sudeep Holla wrote:
[...]
> > +
> > +int ffa_setup_partitions(struct device_node *np)
> > +{
> > + int ret;
> > + struct device_node *child;
> > + struct ffa_device *ffa_dev;
> > + struct ffa_partition_info pbuf;
> > + const char *p_uuid, *pfx = "Ignoring FFA partition";
> > + uuid_t uuid = UUID_INIT(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
> > +
> > + for_each_child_of_node(np, child) {
>
> The spec says:
> – If the Nil UUID is specified at the Non-secure virtual FF-A instance,
> the Hypervisor must provide information for partitions resident in both
> security states.
>
That was my initial understanding of the specification. However I was told
it is designed mostly for Non-Secure Hypervisor for getting the list of
secure partitions and help in allocation of non-secure partition/endpoint IDs.
This has been topic of discussion recently.
> Doesn't that make this redundant?
>
Not exactly. One main reason why the discovery API (get partition info) is
not much useful here in this context is that it lacks UUID and hence not much
of use unless you know UUID. The result we get for Nil UUID needs to be mapped
to UUID and I can't think of anyway to do so outside the scope of the spec.
I have raised it but not sure if there is a strong requirement to add it.
Similarly, I would have like 32 vs 64 bit capable partition info from there
ideally, but we are here now.
--
Regards,
Sudeep
