On Thu, Jan 07, 2021 at 01:22:06PM +0800, Hsin-Yi Wang wrote: > Similar to krane-sku176 but using a different panel source. > > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> > --- > Change: > v2: move compatible to board dts > --- > .../devicetree/bindings/arm/mediatek.yaml | 1 + > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++ > 3 files changed, 25 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 53f0d4e3ea982..3276f7a2ce672 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -120,6 +120,7 @@ properties: > - const: mediatek,mt8183 > - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) > items: > + - const: google,krane-sku0 > - const: google,krane-sku176 > - const: google,krane > - const: mediatek,mt8183 This says you must have all 4 compatible strings in the order listed. That doesn't match your dts. I assume you want the first 2 under an 'enum' so there's 3 strings with the first one being sku0 or sku176? Rob
