On 21/12/2020 11:45, Gene Chen wrote:
> From: Gene Chen <gene_chen@xxxxxxxxxxx>
[...]
> +
> +static const struct of_device_id __maybe_unused mt6360_led_of_id[] = {
> + { .compatible = "mediatek,mt6360-led", },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, mt6360_led_of_id);
> +
I think we should fix MFD code to not need to use a DT binding here. See [1].
Regards,
Matthias
[1] https://lore.kernel.org/linux-mediatek/20210111164118.GE4728@xxxxxxxxxxxxx/
> +static struct platform_driver mt6360_led_driver = {
> + .driver = {
> + .name = "mt6360-led",
> + .of_match_table = mt6360_led_of_id,
> + },
> + .probe = mt6360_led_probe,
> + .remove = mt6360_led_remove,
> +};
> +module_platform_driver(mt6360_led_driver);
> +
> +MODULE_AUTHOR("Gene Chen <gene_chen@xxxxxxxxxxx>");
> +MODULE_DESCRIPTION("MT6360 LED Driver");
> +MODULE_LICENSE("GPL v2");
>
