On Mon, 2021-01-11 at 13:06 -0600, Rob Herring wrote: > On Fri, Jan 08, 2021 at 03:34:52PM +0200, Matti Vaittinen wrote: > > Document DT bindings for ROHM BD71815. > > > > BD71815 is a single-chip power management IC mainly for battery- > > powered > > portable devices. The IC integrates 5 bucks, 7 LDOs, a boost driver > > for > > LED, a battery charger with a Coulomb counter, a real-time clock, a > > 32kHz > > clock and two general-purpose outputs although only one is > > documented by > > the data-sheet. > > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> > > --- > > .../bindings/mfd/rohm,bd71815-pmic.yaml | 198 > > ++++++++++++++++++ > > 1 file changed, 198 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/mfd/rohm,bd71815-pmic.yaml > > > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71815- > > pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71815- > > pmic.yaml > > new file mode 100644 > > index 000000000000..2206b2008acd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71815-pmic.yaml > > @@ -0,0 +1,198 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mfd/rohm,bd71815-pmic.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ROHM BD71815 Power Management Integrated Circuit bindings > > + > > +maintainers: > > + - Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> > > + > > +description: | > > + BD71815AGW is a single-chip power management ICs for battery- > > powered > > + portable devices. It integrates 5 buck converters, 8 LDOs, a > > boost driver > > + for LED and a 500 mA single-cell linear charger. Also included > > is a Coulomb > > + counter, a real-time clock (RTC), and a 32.768 kHz clock gate > > and two GPOs. > > + > > +properties: > > + compatible: > > + const: rohm,bd71815 > > + > > + reg: > > + description: > > + I2C slave address. > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + gpio-controller: true > > Add a blank line here. > > > + "#gpio-cells": > > + const: 2 > > + description: | > > + The first cell is the pin number and the second cell is used > > to specify > > + flags. See ../gpio/gpio.txt for more information. > > + > > + clocks: > > + maxItems: 1 > > And here. > > > + "#clock-cells": > > + const: 0 > > And here. > > > + clock-output-names: > > + const: bd71815-32k-out > > + > > + rohm,clkout-mode: > > + description: clk32kout mode. Can be set to "open-drain" or > > "cmos". > > + $ref: "/schemas/types.yaml#/definitions/string" > > + enum: > > + - open-drain > > + - cmos > > + > > + rohm,charger-sense-resistor-ohms: > > + minimum: 10000000 > > + maximum: 50000000 > > + description: | > > + BD71827 and BD71828 have SAR ADC for measuring charging > > currents. > > + External sense resistor (RSENSE in data sheet) should be > > used. If some > > + other but 30MOhm resistor is used the resistance value > > should be given > > 'something other' > > Though this can be expressed as 'default: 30000000' I guess I'll use both 'something other' and 'default: 30000000' in next version. 'default: 30000000' is nice for machine parser - but for human reader the 'something other' is likely to be superior. (No scientific test conducted to back off this statement though). Thanks Rob! Best Regards Matti Vaittinen