On Fri, Jan 08, 2021 at 01:25:45PM -0800, mgross@xxxxxxxxxxxxxxx wrote: > From: Seamus Kelly <seamus.kelly@xxxxxxxxx> > > Add device tree bindings for keembay-xlink. > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Reviewed-by: Mark Gross <mgross@xxxxxxxxxxxxxxx> > Signed-off-by: Seamus Kelly <seamus.kelly@xxxxxxxxx> > Signed-off-by: Ryan Carnaghi <ryan.r.carnaghi@xxxxxxxxx> > --- > .../bindings/misc/intel,keembay-xlink.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml > > diff --git a/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml > new file mode 100644 > index 000000000000..89c34018fa04 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml > @@ -0,0 +1,27 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (c) Intel Corporation. All rights reserved. > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/misc/intel,keembay-xlink.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > + > +title: Intel Keem Bay xlink > + > +maintainers: > + - Seamus Kelly <seamus.kelly@xxxxxxxxx> > + > +description: | > + The Keem Bay xlink driver enables the communication/control sub-system > + for internal and external communications to the Intel Keem Bay SoC. > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: intel,keembay-xlink > + > +examples: > + - | > + xlink { > + compatible = "intel,keembay-xlink"; > + }; A node with a compatible and nothing else is generally a sign of abusing DT to instantiate a driver. You don't need DT for that. Rob
