On Mon, Jan 11, 2021 at 12:22:36PM +0200, Andy Shevchenko wrote: > On Mon, Jan 11, 2021 at 10:26:25AM +0100, Stephan Gerhold wrote: > > On Mon, Jan 11, 2021 at 09:36:12AM +0100, Marco Felsch wrote: > > > On 21-01-08 20:23, Stephan Gerhold wrote: > > ... > > > > > + if (error) > > > > + return dev_err_probe(&client->dev, error, > > > > + "failed to request regulators\n"); > > > > > > It would be nice to have a patch in front of this one which handles the > > > support for dev_err_probe(). > > > > > > > OK, I can send a v2 with the dev_err_probe() change separated into an > > extra patch. > > AFAIR Dmitry has strong opinion against dev_err_probe(). But I might be > mistaken. > Hmm, yeah actually it seems like there was a patch for this already: https://lore.kernel.org/linux-input/20200827185829.30096-12-krzk@xxxxxxxxxx/ I guess it's better to not include this here then... Thanks, Stephan