On Mon, Dec 28, 2020 at 10:59:39AM +0800, Qing Zhang wrote: > Switch the DT binding to a YAML schema to enable the DT validation. > > Reviewed-by: Huacai Chen <chenhuacai@xxxxxxxxxx> > Signed-off-by: Qing Zhang <zhangqing@xxxxxxxxxxx> > --- > > v4: > - fix warnings/errors about running 'make dt_binding_check' > > v5: > - remove num-chipelects > > v6: > - No changes > > --- > .../devicetree/bindings/spi/loongson,spi-ls7a.yaml | 44 ++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/loongson,spi-ls7a.yaml > > diff --git a/Documentation/devicetree/bindings/spi/loongson,spi-ls7a.yaml b/Documentation/devicetree/bindings/spi/loongson,spi-ls7a.yaml > new file mode 100644 > index 0000000..b90b28b > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/loongson,spi-ls7a.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/loongson,spi-ls7a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson LS7A PCH SPI Controller > + > +maintainers: > + - Qing Zhang <zhangqing@xxxxxxxxxxx> > + > +description: | > + This controller can be found in Loongson-3 systems with LS7A PCH. allOf: - $ref: spi-controller.yaml# > + > +properties: > + compatible: > + const: loongson,ls7a-spi > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + pci { > + #address-cells = <3>; > + #size-cells = <2>; > + > + spi@16,0 { > + compatible = "pci0014,7a0b.0", > + "pci0014,7a0b", > + "pciclass088000", > + "pciclass0800"; Doesn't match the schema. If this is on PCI bus, then the example is correct. Though you could drop some of the strings. And I think leading 0s should be omitted. So 'pci14,7a0b'. But please double check that. Rob