On Wed, Jan 6, 2021 at 6:47 PM Nicolas Boichat <drinkcat@xxxxxxxxxxxx> wrote:
>
> On Wed, Jan 6, 2021 at 4:46 PM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote:
> >
> > Config dsi node for mt8183 kukui. Set panel and ports.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> > ---
> > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 38 +++++++++++++++++++
> > 1 file changed, 38 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > index bf2ad1294dd30..4cfb3560e5d11 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > @@ -249,6 +249,36 @@ &cpu7 {
> > proc-supply = <&mt6358_vproc11_reg>;
> > };
> >
> > +&dsi0 {
> > + status = "okay";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + panel: panel@0 {
> > + compatible = "boe,tv101wum-nl6";
>
> We're going to have many panels in the kukui family, so I think I'd
> prefer it if you moved the compatible string to krane-sku0 dts: it
> makes it easier to figure out what's different with sku0.
I meant sku176 (since you are adding sku0 with a different panel
compatible later).
>
> Then maybe leave all the other properties in this file, as it seems
> like all MIPI panels use the exact same pin/supplies?
>
> (And add a comment here saying that the compatible needs to be set in
> board dts?)
>
> > + reg = <0>;
> > + enable-gpios = <&pio 45 0>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&panel_pins_default>;
> > + avdd-supply = <&ppvarn_lcd>;
> > + avee-supply = <&ppvarp_lcd>;
> > + pp1800-supply = <&pp1800_lcd>;
> > + status = "okay";
> > + port {
> > + panel_in: endpoint {
> > + remote-endpoint = <&dsi_out>;
> > + };
> > + };
> > + };
> > +
> > + ports {
> > + port {
> > + dsi_out: endpoint {
> > + remote-endpoint = <&panel_in>;
> > + };
> > + };
> > + };
> > +};
> > +
> > &i2c0 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&i2c0_pins>;
> > @@ -547,6 +577,14 @@ pins_clk {
> > };
> > };
> >
> > + panel_pins_default: panel_pins_default {
> > + panel_reset {
> > + pinmux = <PINMUX_GPIO45__FUNC_GPIO45>;
> > + output-low;
> > + bias-pull-up;
> > + };
> > + };
> > +
> > pwm0_pin_default: pwm0_pin_default {
> > pins1 {
> > pinmux = <PINMUX_GPIO176__FUNC_GPIO176>;
> > --
> > 2.29.2.729.g45daf8777d-goog
> >
