On Tue, Jan 5, 2021 at 7:14 AM Vinod Koul <vkoul@xxxxxxxxxx> wrote: > On 04-01-21, 12:37, Bjorn Andersson wrote: > > > > > +properties: > > > > + compatible: > > > > + const: qcom,sm8350-pinctrl > > > > > > If this block is called TLMM, then I'd expect that to be in the > > > compatible string. But I guess this is consistent with the others. > > > > > > > This is my mistake 7 years ago and it bothers me every time we write a > > new one of these - in particular since we now support a few different > > "Qualcomm pinctrl" blocks. > > > > It would be ugly for a while, but I'm in favor of naming these > > "qcom,<platform>-tlmm" going forward. > > > > PS. And we can solve the ugliness by introducing the "proper" naming > > (and keeping the old one for backwards compatibility) as we migrate the > > binding documents to yaml. > > Okay I will update this one to qcom,sm8350-tlmm. Also we use > sm8350_pinctrl few places in the driver, will update that to sm8350_tlmm > as well Go for it, it's a much better to the point name. Yours, Linus Walleij
