Hi Niklas, On Thu, Nov 26, 2020 at 11:30 PM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > Add support for thermal. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > @@ -91,6 +91,18 @@ sysc: system-controller@e6180000 { > #power-domain-cells = <1>; > }; > > + tsc: thermal@e6190000 { > + compatible = "renesas,r8a779a0-thermal"; > + reg = <0 0xe6190000 0 0x100>, > + <0 0xe6198000 0 0x100>, > + <0 0xe61a0000 0 0x100>, > + <0 0xe61a8000 0 0x100>; The fifth region at 0x161b0000 is missing. > + clocks = <&cpg CPG_MOD 919>; > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > + resets = <&cpg 919>; > + #thermal-sensor-cells = <1>; > + }; > + > scif0: serial@e6e60000 { > compatible = "renesas,scif-r8a779a0", > "renesas,rcar-gen3-scif", "renesas,scif"; > @@ -123,6 +135,64 @@ prr: chipid@fff00044 { > }; > }; > > + thermal-zones { > + sensor_thermal1: sensor-thermal1 { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&tsc 0>; > + > + trips { > + sensor1_crit: sensor1-crit { > + temperature = <120000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + sensor_thermal2: sensor-thermal2 { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&tsc 1>; > + > + trips { > + sensor2_crit: sensor2-crit { > + temperature = <120000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + sensor_thermal3: sensor-thermal3 { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&tsc 2>; > + > + trips { > + sensor3_crit: sensor3-crit { > + temperature = <120000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; > + > + sensor_thermal4: sensor-thermal4 { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&tsc 3>; > + > + trips { > + sensor4_crit: sensor4-crit { > + temperature = <120000>; > + hysteresis = <1000>; > + type = "critical"; > + }; > + }; > + }; Missing fifth entry. > + }; > + > timer { > compatible = "arm,armv8-timer"; > interrupts-extended = <&gic GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds