On Wed, Dec 9, 2020 at 10:07 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Mon, Nov 30, 2020 at 04:11:38PM -0500, Jim Quinlan wrote: > > Quite similar to the regulator bindings found in "rockchip-pcie-host.txt", > > this allows optional regulators to be attached and controlled by the > > PCIe RC driver. > > > > Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx> > > --- > > .../devicetree/bindings/pci/brcm,stb-pcie.yaml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > index 807694b4f41f..baacc3d7ec87 100644 > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > @@ -85,6 +85,18 @@ properties: > > minItems: 1 > > maxItems: 3 > > > > + vpcie12v-supply: > > + description: 12v regulator phandle for the endpoint device > > + > > + vpcie3v3-supply: > > + description: 3.3v regulator phandle for the endpoint device > > 12V and 3.3V are standard slot supplies, can you add them to > pci-bus.yaml. Then some day maybe we can have common slot handling code. > > With that, here you just need: > > vpcie3v3-supply: true Hi Rob, Sorry for the delay in responding -- I just came back from vacation. The problem we have is that these regulators are not "slot" supplies -- our HW does not support PCI slots, so if and when general slot power-handling code came along it would probably screw us up. If you don't think there is a problem then I will submit the two supply-names you OKed, even though they may not match the voltages we are using for the EPs. For us, the supplies are for the EP chip's power. We have the PCIe controller turning them "on" for power-on/resume and "off" for power-off/suspend. We need the "xxx-supply" property in the controller's DT node because of the chicken-and-egg situation: if the property was in the EP's DT node, the RC will never discover the EP to see that there is a regulator to turn on. We would be happy with a single supply name, something like "ep-power". We would be ecstatic to have two (ep0-power, ep1-power). I'm not sure if you remember but FlorianF talked to you about this situation and concluded that something like the above was the way to go forward. For the latest pullreq I just copied Rockchip's bindings since you reviewed their bindings commit but it looks like you've changed your mind. Given the constraints I have described, what is the best path forward? Thanks, Jim Quinlan Broadcom STB > > > + > > + vpcie1v8-supply: > > + description: 1.8v regulator phandle for the endpoint device > > + > > + vpcie0v9-supply: > > + description: 0.9v regulator phandle for the endpoint device > > These are not standard. They go to a soldered down device or > non-standard connector? For the former, the device should really be > described in DT and the supplies added there. > > Mini PCIe connector also has 1.5V supply. > > Rob
