On Thu, 2020-12-31 at 09:21 +0800, Nicolas Boichat wrote: > On Mon, Dec 28, 2020 at 4:38 PM Yongqiang Niu > <yongqiang.niu@xxxxxxxxxxxx> wrote: > > > > the mmsys will more and more complicated after support > > more and more SoCs, add an independent folder will be > > more clear > > > > Signed-off-by: Yongqiang Niu <yongqiang.niu@xxxxxxxxxxxx> > > --- > > drivers/soc/mediatek/Makefile | 2 +- > > drivers/soc/mediatek/mmsys/Makefile | 2 + > > drivers/soc/mediatek/mmsys/mtk-mmsys.c | 380 +++++++++++++++++++++++++++++++++ > > drivers/soc/mediatek/mtk-mmsys.c | 380 --------------------------------- > > I wonder why this doesn't get detected as a rename? > git commit --amend [detached HEAD 1f10c05] soc: mediatek: mmsys: create mmsys folder 3 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 drivers/soc/mediatek/mmsys/Makefile rename drivers/soc/mediatek/{ => mmsys}/mtk-mmsys.c (100%) > > 4 files changed, 383 insertions(+), 381 deletions(-) > > create mode 100644 drivers/soc/mediatek/mmsys/Makefile > > create mode 100644 drivers/soc/mediatek/mmsys/mtk-mmsys.c > > delete mode 100644 drivers/soc/mediatek/mtk-mmsys.c > > > > diff --git a/drivers/soc/mediatek/Makefile b/drivers/soc/mediatek/Makefile > > index 01f9f87..b5987ca 100644 > > --- a/drivers/soc/mediatek/Makefile > > +++ b/drivers/soc/mediatek/Makefile > > @@ -3,4 +3,4 @@ obj-$(CONFIG_MTK_CMDQ) += mtk-cmdq-helper.o > > obj-$(CONFIG_MTK_INFRACFG) += mtk-infracfg.o > > obj-$(CONFIG_MTK_PMIC_WRAP) += mtk-pmic-wrap.o > > obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o > > -obj-$(CONFIG_MTK_MMSYS) += mtk-mmsys.o > > +obj-$(CONFIG_MTK_MMSYS) += mmsys/ > > diff --git a/drivers/soc/mediatek/mmsys/Makefile b/drivers/soc/mediatek/mmsys/Makefile > > new file mode 100644 > > index 0000000..5d976d7 > > --- /dev/null > > +++ b/drivers/soc/mediatek/mmsys/Makefile > > @@ -0,0 +1,2 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > +obj-$(CONFIG_MTK_MMSYS) += mtk-mmsys.o > > \ No newline at end of file > > Nit: newline at end of file please.