Hi Sebastian, On Sun, Jan 03, 2021 at 04:26:31AM +0100, Sebastian Reichel wrote: > Hi, > > On Tue, Dec 29, 2020 at 07:31:20PM +0200, Cristian Ciocaltea wrote: > > This driver provides poweroff and reboot support for a system through > > the ATC2603C and ATC2609A chip variants of the Actions Semi ATC260x > > family of PMICs. > > > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxx> > > --- > > Changes in v4: > > - None > > > > Changes in v3: > > - Removed the unnecessary driver compatibles > > > > [...] > > +#include <linux/delay.h> > > +#include <linux/mfd/atc260x/core.h> > > +#include <linux/module.h> > > +#include <linux/of.h> > > There is no DT code in this driver? Right, this line is not needed anymore, I will drop it and submit a new patch revision. > > +#include <linux/platform_device.h> > > +#include <linux/power_supply.h> > > power_supply.h? That's for chargers and battery fuel gauges. That is only used for checking if the S4 mode is available - which involves calling 'power_supply_is_system_supplied()'. > > +#include <linux/reboot.h> > > +#include <linux/regmap.h> > > > [...] > > Otherwise LGTM. I suppose I can cherry-pick this patch into > my tree, or did I miss some dependencies? I'm not really sure what is the recommended approach (if any) for merging MFD drivers. The only dependency is the PMIC core driver in patch 3/7, which is handled in Kconfig through 'depends on MFD_ATC260X'. So far, Mark applied the regulator driver patch to his tree, while Dmitry suggested to merge the onkey driver through MFD. So I think both approaches are fine. @Lee: Do you have any preference or recommendation for handling this? > -- Sebastian Thanks for the review, Cristi
