On Mon, Dec 21, 2020 at 4:34 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Mon, Dec 21, 2020 at 4:15 PM Alexandru Ardelean > <alexandru.ardelean@xxxxxxxxxx> wrote: > > > > From: Dragos Bogdan <dragos.bogdan@xxxxxxxxxx> > > > > Transmit/receive only is a valid SPI mode. For example, the MOSI/TX line > > might be missing from an ADC while for a DAC the MISO/RX line may be > > optional. This patch adds these two new modes: SPI_NO_TX and > > SPI_NO_RX. This way, the drivers will be able to identify if any of > > these two lines is missing and to adjust the transfers accordingly. > > > > Signed-off-by: Dragos Bogdan <dragos.bogdan@xxxxxxxxxx> > > Missed Co-developed-by: Alexandru ... ? > > Anyway, looks good to me, > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> One nit, though... > > - "setup: can not select dual and quad at the same time\n"); > > + "setup: can not select any two of dual, quad and no-rx/tx " > > + "at the same time\n"); Can we avoid splitting string literals which are assumed to be on one line when printed? -- With Best Regards, Andy Shevchenko
