On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote: > On 10.12.2020 22:29, Krzysztof Kozlowski wrote: > > Interrupt line can be configured on different hardware in different way, > > even inverted. Therefore driver should not enforce specific trigger > > type - edge falling - but instead rely on Devicetree to configure it. > > > > The Samsung PMIC drivers are used only on Devicetree boards. > > > > Additionally, the PMIC datasheets describe the interrupt line as active > > low with a requirement of acknowledge from the CPU therefore the edge > > falling is not correct. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > > It looks that this together with DTS change fixes RTC alarm failure that > I've observed from time to time on TM2e board! Great! I'll add this to the commit msg. Thanks for testing. Best regards, Krzysztof > > > --- > > > > This patch should wait till DTS changes are merged, as it relies on > > proper Devicetree. > > ---
