> -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: 2020年12月18日 17:37 > To: Alice Guo (OSS) <alice.guo@xxxxxxxxxxx> > Cc: robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; > kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx > <linux-imx@xxxxxxx> > Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc > unique ID > > On Fri, Dec 18, 2020 at 09:05:00AM +0000, Alice Guo (OSS) wrote: > > > + required: > > > > + - compatible > > > > + - nvmem-cells > > > > + - nvmem-cell-names > > > > + > > > > +additionalProperties: true > > > > > > Don't leave comments unresolved (or resolve them against review > > > without discussion). Rob asked for changing it. The same as with all > > > schemas - you need to describe the missing properties. > > > > > > Best regards, > > > Krzysztof > > > > Hi, > > Thank you for your advice. I replied to him and let him know I remained here > unchanged. There will be errors according to his suggestion. > > Then the solution is to correct the errors - describe missing properties > - instead of ignoring the suggestion and making a resubmit right away. > > Best regards, > Krzysztof Hi, I am sorry I do not DT Binding doc very well. I checked the usage of patternProperties and additionalProperties in https://json-schema.org/understanding-json-schema/reference/object.html. I noticed a sentence on the website: " If additionalProperties is a boolean and set to false, no additional properties will be allowed.", so I think that if additionalProperties is a boolean and set to true, additional properties will be allowed. Letting here unchanged is my solution to correct the errors. I am not sure, I asked Rob for advice on the v6 by email, but he didn't reply to me, so I made a resubmit. Thank you for your comment again. Best regards, Alice
