On Wed, Dec 16, 2020 at 5:27 AM Adrien Grassein <adrien.grassein@xxxxxxxxx> wrote: > > nxp,phase-shift is an enum so use enum format to describe it. > Minimum and maximum values are also wrong. > > Signed-off-by: Adrien Grassein <adrien.grassein@xxxxxxxxx> > --- > .../bindings/regulator/nxp,pf8x00-regulator.yaml | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml > index 913532d0532e..1da724c6e2ba 100644 > --- a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml > @@ -60,21 +60,13 @@ properties: > > nxp,phase-shift: > $ref: "/schemas/types.yaml#/definitions/uint32" > - minimum: 45 > - maximum: 0 > + minimum: 0 > + maximum: 315 > + default: 0 > + enum: [ 0, 45, 90, 135, 180, 225, 270, 315 ] On Wed, Dec 16, 2020 at 5:27 AM Adrien Grassein <adrien.grassein@xxxxxxxxx> wrote: > > pf8x00 module build was not documented. > > Signed-off-by: Adrien Grassein <adrien.grassein@xxxxxxxxx> > --- > drivers/regulator/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > index 53fa84f4d1e1..9c6508e99fdd 100644 > --- a/drivers/regulator/Kconfig > +++ b/drivers/regulator/Kconfig > @@ -828,6 +828,10 @@ config REGULATOR_PF8X00 > Say y here to support the regulators found on the NXP > PF8100/PF8121A/PF8200 PMIC. > > + Say M here if you want to support for the regulators found > + on the NXP PF8100/PF8121A/PF8200 PMIC. The module will be named > + "pf8x00-regulator". Reviewed-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
