On 2020/12/17 19:49, Stephen Boyd wrote: > Quoting Damien Le Moal (2020-12-17 02:43:50) >> >> I just did that. It works. >> >> Ideally, patches 7, 8 and 9 need to go in together with the clk driver patch. >> Since the builtin DTB patch precedes the clock driver patch that touches the >> sysctl driver, I need to rework it a little, keeping the >> SOC_DECLARE_BUILTIN_DTB() for now. And finally, a small DTS update patch needs >> to be added too for the sysctl & sysclk nodes update. That would make it a 5 >> patch series for the clock driver addition. Would this work ? >> >> Or, you just take patch 9 (clk doc) and patch 13 (clk driver), slightly modified >> to move the sysctl register definitions into a common header (currently part of >> patch 7). 2 patches only, without any other change, resulting in the clock >> driver not being used until the rest of the series goes into 5.12. Do you prefer >> that solution ? >> > > I was thinking of just applying this DT binding patch now so it gets > merged into the next -rc1. Then anyone can use the defines because > they're in Linus' tree and wherever the dts file ends up can just base > on -rc1. I probably won't merge the clk driver until v5.12 given that > the merge window is open. > One more thing: to avoid dt-binding checks error for this patch, can you also take patch 8 that adds "canaan" as a vendor name ? -- Damien Le Moal Western Digital Research