Hi Prabhakar, On Tue, Dec 15, 2020 at 03:57:32PM +0000, Lad, Prabhakar wrote: > Hi Jacopo, > > Thank you for the review. > > On Tue, Dec 15, 2020 at 11:49 AM Jacopo Mondi <jacopo@xxxxxxxxxx> wrote: > > > > Hello, > > > > On Thu, Nov 26, 2020 at 10:30:53AM +0000, Lad Prabhakar wrote: > > > The 8-bit ov7725 sensors can also be connected to the camera daughter > > > board. > > > > > > This patch creates a separate dtsi file for ov7725 sensors and is included > > > in r8a7742-iwg21d-q7-dbcm-ca.dts. The user can set VINx_SENSOR depending > > > on the cameras connected. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > --- > > > .../boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 7 ++ > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725.dtsi | 112 ++++++++++++++++++ > > > 2 files changed, 119 insertions(+) > > > create mode 100644 arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725.dtsi > > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > index 1ab4f9771a34..915ff5fd437c 100644 > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > @@ -11,6 +11,7 @@ > > > > > > #define SENSOR_NONE 1 > > > #define SENSOR_OV5640 2 > > > +#define SENSOR_OV7725 3 > > > > > > /* 8bit CMOS Camera 1 (J13) */ > > > #define CAM1_PARENT_I2C i2c0 > > > @@ -40,6 +41,11 @@ > > > * VIN2 interface and also the ov5640 node connected to it) > > > * #define VIN2_SENSOR SENSOR_NONE > > > * > > > + * To tie VINx endpoints to ov7725_x endpoints set VINx_SENSOR to > > > + * SENSOR_OV7725 for example if ov7725_3 is connected to the VIN3 > > > + * interface set the below (this disables the ov5640_3) > > > + * #define VIN3_SENSOR SENSOR_OV7725 > > > + * > > > */ > > > #define VIN0_SENSOR SENSOR_OV5640 > > > #define VIN1_SENSOR SENSOR_OV5640 > > > @@ -47,6 +53,7 @@ > > > #define VIN3_SENSOR SENSOR_OV5640 > > > > > > #include "r8a7742-iwg21d-q7-dbcm-ov5640.dtsi" > > > +#include "r8a7742-iwg21d-q7-dbcm-ov7725.dtsi" > > > > Mmm, can't we alternatively include one .dtsi or the other depending > > on a define symbol ? The .dtsi describe pluggable expansion boards, > > they cannot be mixed, right ? > > > Since the cameras on the daughter can be mixed and matched a much > better version of the patches [1] which handle this case elegantly has > been posted by Geert. > > [1] https://patchwork.kernel.org/project/linux-renesas-soc/cover/20201126134031.4115211-1-geert@xxxxxxxxxxxxxx/ Oh, I see the discussion know, sorry for the noise. > > Cheers, > Prabhakar
