Re: [PATCH 1/6] arm64: dts: renesas: r8a77951: Add TMU nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Niklas,

On Wed, Dec 9, 2020 at 9:20 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> Add device nodes for the Timer Unit (TMU) on the Renesas R-Car H3
> (r8a77951) SoC.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi

> +               tmu4: timer@ffc00000 {
> +                       compatible = "renesas,tmu-r8a7795", "renesas,tmu";
> +                       reg = <0 0xffc00000 0 0x30>;
> +                       interrupts = <GIC_SPI 438 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 439 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 440 IRQ_TYPE_LEVEL_HIGH>;

These interrupt numbers are wrong: they should be 406, 407, and 408.
The rest looks good to me.
Same comment for the other 5 patches.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux