On Thu, Dec 03, 2020 at 05:16:51PM +0900, Punit Agrawal wrote: > Iwamatsu-san, > > Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> writes: > > > Add bindings for the Toshiba Visconti GPIO Controller. > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > > --- > > .../bindings/gpio/toshiba,gpio-visconti.yaml | 85 +++++++++++++++++++ > > 1 file changed, 85 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > > > diff --git a/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > new file mode 100644 > > index 000000000000..5168a15b90e1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > @@ -0,0 +1,85 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gpio/toshiba,gpio-visconti.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Toshiba Visconti ARM SoCs GPIO controller > > + > > +maintainers: > > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + items: > > + - const: toshiba,gpio-tmpv7708 > > + > > + reg: > > + maxItems: 1 > > + > > + "#gpio-cells": > > + const: 2 > > + > > + gpio-ranges: true > > I am not sure I have a good handle on the yaml schema definitions but > "gpio-ranges" feels like it should be a list of ranges not a boolean. > > Something like - > > gpio-ranges: > maxItems: 1 > > feels more appropriate. > > I see both the usages in gpio bindings and for other range properties so > maybe it's OK. I hope Rob or somebody more knowledgeable on this can > clarify the usage. If you know how many (or a range) entries there are for gpio-ranges, then maxItems is good. If you don't, then 'gpio-ranges: true' is fine. That doesn't make the property a boolean, but just says the property can be present. Rob
