Gentle ping.. and Krzysztof Kozlowski, do you agree? Best Regards, Alice Guo > -----Original Message----- > From: linux-arm-kernel <linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx> On > Behalf Of Alice Guo (OSS) > Sent: 2020年12月1日 11:31 > To: Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk@xxxxxxxxxx>; > shawnguo@xxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx; Peng Fan <peng.fan@xxxxxxx>; > s.hauer@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; krzk@xxxxxxxxxx; > dl-linux-imx <linux-imx@xxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: RE: [PATCH v6 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc > unique ID > > > > > -----Original Message----- > > From: linux-arm-kernel <linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx> > > On Behalf Of Rob Herring > > Sent: 2020年12月1日 5:57 > > To: Alice Guo <alice.guo@xxxxxxx> > > Cc: devicetree@xxxxxxxxxxxxxxx; Peng Fan <peng.fan@xxxxxxx>; > > s.hauer@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; krzk@xxxxxxxxxx; > > dl-linux-imx <linux-imx@xxxxxxx>; shawnguo@xxxxxxxxxx; > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > Subject: Re: [PATCH v6 1/4] dt-bindings: soc: imx8m: add DT Binding > > doc for soc unique ID > > > > On Tue, Nov 24, 2020 at 09:59:46AM +0800, Alice Guo wrote: > > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > > > > > Signed-off-by: Alice Guo <alice.guo@xxxxxxx> > > > --- > > > > > > v2: remove the subject prefix "LF-2571-1" > > > v3: put it into Documentation/devicetree/bindings/arm/fsl.yaml > > > > No, I prefer this be a separate schema file and not clutter board/soc > > schemas with child nodes. > > Hi, > Thank you for your comments. I read > "Documentation/devicetree/bindings/arm/arm,realview.yaml" > in which there is a "soc". So I added my "soc" to this current file. Can I keep it in > Documentation/devicetree/bindings/arm/fsl.yaml? > > > > modify the description of nvmem-cells > > > use "make ARCH=arm64 dtbs_check" to test it and fix errors > > > v4: use allOf to limit new version DTS files for i.MX8M to include > > > "fsl,imx8mm/n/p/q-soc", nvmem-cells and nvmem-cells-names > > > v5: correct the error of using allOf > > > v6: none > > > > > > .../devicetree/bindings/arm/fsl.yaml | 47 > > +++++++++++++++++++ > > > 1 file changed, 47 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > > index 67980dcef66d..7132ffd41abb 100644 > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > @@ -918,6 +918,53 @@ properties: > > > - fsl,s32v234-evb # S32V234-EVB2 Customer > > Evaluation Board > > > - const: fsl,s32v234 > > > > > > + soc: > > > + type: object > > > + properties: > > > + compatible: > > > + oneOf: > > > + - description: new version compatible for i.MX8M SoCs > > > + items: > > > + - enum: > > > + - fsl,imx8mm-soc > > > + - fsl,imx8mn-soc > > > + - fsl,imx8mp-soc > > > + - fsl,imx8mq-soc > > > + - const: simple-bus > > > + > > > + - description: old version compatible for i.MX8M SoCs > > > + items: > > > + - const: simple-bus > > > > Fix your dts files and drop this. > > My changes are below. > > > > > > + > > > +allOf: > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - fsl,imx8mm > > > + - fsl,imx8mn > > > + - fsl,imx8mp > > > + - fsl,imx8mq > > > + > > > + then: > > > + patternProperties: > > > + "^soc@[0-9a-f]+$": > > > > And this is just wrong. First you say the node is 'soc' and then here > > it has a unit address. > > Here are my changes. I deleted the section from "soc:" to "- const: simple bus". > Please help me to see if they are correct and workable. Thank you. > allOf: > - if: > properties: > compatible: > contains: > enum: > - fsl,imx8mm > - fsl,imx8mn > - fsl,imx8mp > - fsl,imx8mq > > then: > patternProperties: > "^soc@[0-9a-f]+$": > properties: > compatible: > items: > - enum: > - fsl,imx8mm-soc > - fsl,imx8mn-soc > - fsl,imx8mp-soc > - fsl,imx8mq-soc > - const: simple-bus > > required: > - compatible > - nvmem-cells > - nvmem-cell-names > > Best Regards, > Alice Guo > > > > > > > + properties: > > > + compatible: > > > + items: > > > + - enum: > > > + - fsl,imx8mm-soc > > > + - fsl,imx8mn-soc > > > + - fsl,imx8mp-soc > > > + - fsl,imx8mq-soc > > > + - const: simple-bus > > > + > > > + required: > > > + - compatible > > > + - nvmem-cells > > > + - nvmem-cell-names > > > + > > > additionalProperties: true > > > > > > ... > > > -- > > > 2.17.1 > > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
