On Fri, Dec 04, 2020 at 01:13:52AM +0100, AngeloGioacchino Del Regno wrote: > Il 03/12/20 12:14, Manivannan Sadhasivam ha scritto: > > Hi, > > > > On Mon, Nov 30, 2020 at 10:23:05AM -0700, Rob Herring wrote: > > > On Thu, 26 Nov 2020 19:45:57 +0100, AngeloGioacchino Del Regno wrote: > > > > Convert the qcom-cpufreq-hw documentation to YAML binding as > > > > qcom,cpufreq-hw.yaml. > > > > > > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx> > > > > There is already a patch floating for this. Please see: > > https://lkml.org/lkml/2020/10/20/676 > > > > Thanks, > > Mani > > > Oh, I'm sorry, I wasn't aware of that, didn't want to step on you. > > Should I rebase patch 1345789 (patch 13/13 of this series) on top of > the one that you pointed out and drop this one? Yes please. Thanks, Mani > > - Angelo > > > > > --- > > > > .../bindings/cpufreq/cpufreq-qcom-hw.txt | 173 +--------------- > > > > .../bindings/cpufreq/qcom,cpufreq-hw.yaml | 196 ++++++++++++++++++ > > > > 2 files changed, 197 insertions(+), 172 deletions(-) > > > > create mode 100644 Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.yaml > > > > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.yaml: properties:clock-names: [{'const': 'xo'}, {'const': 'ref'}] is not of type 'object', 'boolean' > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.yaml: maintainers:0: 'TBD' is not a 'email' > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.yaml: ignoring, error in schema: properties: clock-names > > > warning: no schema found in file: ./Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.yaml > > > Error: Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.example.dts:150.3-151.1 syntax error > > > FATAL ERROR: Unable to parse input tree > > > make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/cpufreq/qcom,cpufreq-hw.example.dt.yaml] Error 1 > > > make[1]: *** Waiting for unfinished jobs.... > > > make: *** [Makefile:1364: dt_binding_check] Error 2 > > > > > > > > > See https://patchwork.ozlabs.org/patch/1406857 > > > > > > The base for the patch is generally the last rc1. Any dependencies > > > should be noted. > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > > date: > > > > > > pip3 install dtschema --upgrade > > > > > > Please check and re-submit. > > > >