On Mon, Dec 07, 2020 at 09:58:14AM -0600, Rob Herring wrote: > On Tue, 01 Dec 2020 14:35:04 -0800, mgross@xxxxxxxxxxxxxxx wrote: > > From: Seamus Kelly <seamus.kelly@xxxxxxxxx> > > > > Add device tree bindings for the xLink IPC driver which enables xLink to > > control and communicate with the VPU IP present on the Intel Keem Bay > > SoC. > > > > Cc: devicetree@xxxxxxxxxxxxxxx > > Reviewed-by: Mark Gross <mgross@xxxxxxxxxxxxxxx> > > Signed-off-by: Seamus Kelly <seamus.kelly@xxxxxxxxx> > > Signed-off-by: Ryan Carnaghi <ryan.r.carnaghi@xxxxxxxxx> > > --- > > .../misc/intel,keembay-xlink-ipc.yaml | 49 +++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml:21:9: [warning] wrong indentation: expected 10 but found 8 (indentation) > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml: 'additionalProperties' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml: ignoring, error in schema: > warning: no schema found in file: ./Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml > > > See https://patchwork.ozlabs.org/patch/1409186 > > The base for the patch is generally the last rc1. Any dependencies > should be noted. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Thank you! will do. --mark