Re: [PATCH 3/4] bindings: arm: fsl: Add PHYTEC i.MX8MP devicetree bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Montag, den 07.12.2020, 12:59 +0100 schrieb Krzysztof Kozlowski:
> On Fri, Dec 04, 2020 at 09:33:01PM +0100, Teresa Remmet wrote:
> > Add devicetree bindings for i.MX8MP based phyCORE-i.MX8MP
> > and phyBOARD-Pollux RDK.
> > 
> > Signed-off-by: Teresa Remmet <t.remmet@xxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> > b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 934289446abb..880d93092f37 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -433,6 +433,13 @@ properties:
> >                - fsl,imx8mp-evk            # i.MX8MP EVK Board
> >            - const: fsl,imx8mp
> >  
> > +      - description: PHYTEC phyCORE-i.MX8MP SoM based boards
> > +        items:
> > +          - enum:
> > +              - phytec,imx8mp-phycore-som         # phyCORE-
> > i.MX8MP SoM
> > +              - phytec,imx8mp-phyboard-pollux-rdk # phyBOARD-
> > Pollux RDK
> 
> These do not look correct. In this way, you should include them in
> "i.MX8MP based Boards" entry. Probably you wanted all "const"
> instead.

I will change them to "const" in v2. 

Thank you,
Teresa

> 
> Best regards,
> Krzysztof
> 
> 
> > +          - const: fsl,imx8mp
> > +




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux