Mark Rutland <mark.rutland@xxxxxxx> writes:
> On Sat, Jun 21, 2014 at 11:21:47PM +0100, Robert Jarzmik wrote:
>> @@ -1650,6 +1651,64 @@ static struct soc_camera_host_ops pxa_soc_camera_host_ops = {
>> .set_bus_param = pxa_camera_set_bus_param,
>> };
>>
>> +static int pxa_camera_pdata_from_dt(struct device *dev,
>> + struct pxa_camera_dev *pcdev)
>> +{
>> + int err = 0;
>> + struct device_node *np = dev->of_node;
>> + struct v4l2_of_endpoint ep;
>> +
>> + err = of_property_read_u32(np, "clock-frequency",
>> + (u32 *)&pcdev->mclk);
>
> That cast is either unnecessary or this code is broken.
Mmm maybe ...
As a clock rate is an unsigned long by design, where is the
of_property_read_ulong() function ?
> Use a temporary u32 if the types don't match.
If there's no of_*() function available, let's do that.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
