On 06. 12. 20 23:48, Laurent Pinchart wrote: > On Mon, Dec 07, 2020 at 12:46:56AM +0200, Laurent Pinchart wrote: >> Hi Michal, >> >> Thank you for the patch. >> >> On Wed, Dec 02, 2020 at 03:06:05PM +0100, Michal Simek wrote: >>> Add label which is used by bootloader for adding bootloader specific flag. >>> >>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx> >>> --- >>> >>> U-Boot needs to add u-boot,dm-pre-reloc; property >> >> I'm not entirely sure what best practice rules are in this area, but >> shouldn't U-Boot locate the node by name instead of label ? > > And regardless of what mechanism is used, it should be documented in the > bindings. I don't think we should be documenting labels because names can be whatever. DT binding spec is just talking about name rules. 6.2 chapter. A label shall be between - 1 to 31 characters in length, be composed only of the characters in the set Table 6.1, and must not start with a number. - Table 6.1: Valid characters for DTS labels Character Description 0-9 digit a-z lowercase letter A-Z uppercase letter _ underscore Thanks, Michal
