Hi Yifeng, Meanwhile, could you post a RFC version for Uboot based on this version plus comments, so people can test the whole process from programming, booting and kernel? On 11/30/20 1:49 PM, Johan Jonker wrote: > Hi, > > Looks good to me. > Do the maintainers or someone else have any major issues? > Could Miquel indicate if a version 16 must be send for that 'ret' > variable alone or is it OK now? > > > On 11/30/20 11:00 AM, Yifeng Zhao wrote: >> This driver supports Rockchip NFC (NAND Flash Controller) found on RK3308, >> RK2928, RKPX30, RV1108 and other SOCs. The driver has been tested using >> 8-bit NAND interface on the ARM based RK3308 platform. [..] >> +/** >> + * struct rk_ecc_cnt_status: represent a ecc status data. represent the ECC status data. >> + * @err_flag_bit: error flag bit index at register. >> + * @low: ECC count low bit index at register. >> + * @low_mask: mask bit. >> + * @low_bn: ECC count low bit number. >> + * @high: ECC count high bit index at register. >> + * @high_mask: mask bit >> + */