On Sun, Dec 06, 2020 at 12:09:50AM +0100, Linus Walleij wrote:
> On Thu, Dec 3, 2020 at 2:13 PM Stephan Gerhold <stephan@xxxxxxxxxxx> wrote:
>
> > The Samsung touchkey controllers are often used with external pull-up
> > for the interrupt line and the I2C lines, so we might need to enable
> > a regulator to bring the lines into usable state. Otherwise, this might
> > cause spurious interrupts and reading from I2C will fail.
> >
> > Document support for a "vddio-supply" that is enabled by the tm2-touchkey
> > driver so that the regulator gets enabled when needed.
> >
> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> > + vddio-supply:
> > + description: |
> > + Optional regulator that provides digital I/O voltage,
> > + e.g. for pulling up the interrupt line or the I2C pins.
>
> I think the funny pipe | us only needed when you want something to be
> fixed-width like ASCII art or ASCII tables. But no big deal I suppose.
>
Actually, the pipe | effectively means that new lines \n will be
preserved in the parsed output, i.e.
something:
Hello
World
means "Hello World", while
something: |
Hello
World
means "Hello\nWorld\n".
In practice I guess it doesn't make much of a difference for these
descriptions. It also doesn't seem to be used very consistently in
existing device tree bindings, so I think it's fine as-is.
Thanks,
Stephan
