Re: [PATCH v2] media: dt-bindings: coda: Add missing 'additionalProperties'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 17, 2020 at 02:07:52PM -0600, Rob Herring wrote:
> 'additionalProperties' is now required by the meta-schema. Add it for
> coda. As a result, 'interrupts', 'interrupt-names' and 'power-domains'
> need to be reworked to be defined at the top level.
> 
> Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---

Ping! In case it wasn't clear, this should go in via the media tree.

>  .../devicetree/bindings/media/coda.yaml       | 42 +++++++++----------
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/coda.yaml b/Documentation/devicetree/bindings/media/coda.yaml
> index 7bac0057faf7..36781ee4617f 100644
> --- a/Documentation/devicetree/bindings/media/coda.yaml
> +++ b/Documentation/devicetree/bindings/media/coda.yaml
> @@ -44,6 +44,21 @@ properties:
>        - const: per
>        - const: ahb
>  
> +  interrupts:
> +    minItems: 1
> +    items:
> +      - description: BIT processor interrupt
> +      - description: JPEG unit interrupt
> +
> +  interrupt-names:
> +    minItems: 1
> +    items:
> +      - const: bit
> +      - const: jpeg
> +
> +  power-domains:
> +    maxItems: 1
> +
>    resets:
>      maxItems: 1
>  
> @@ -59,6 +74,8 @@ required:
>    - clocks
>    - clock-names
>  
> +additionalProperties: false
> +
>  allOf:
>    - if:
>        properties:
> @@ -68,34 +85,17 @@ allOf:
>      then:
>        properties:
>          interrupts:
> -          items:
> -            - description: BIT processor interrupt
> -            - description: JPEG unit interrupt
> +          minItems: 2
>  
>          interrupt-names:
> -          items:
> -            - const: bit
> -            - const: jpeg
> +          minItems: 2
>      else:
>        properties:
>          interrupts:
> -          items:
> -            - description: BIT processor interrupt
> -
> -  - if:
> -      properties:
> -        compatible:
> -          contains:
> -            enum:
> -              - fsl,imx6dl-vpu
> -              - fsl,imx6q-vpu
> -    then:
> -      properties:
> -        power-domains:
> -          $ref: /schemas/types.yaml#/definitions/phandle
> -          description: phandle pointing to the PU power domain
>            maxItems: 1
>  
> +        power-domains: false
> +
>  examples:
>    - |
>      vpu: video-codec@63ff4000 {
> -- 
> 2.25.1
> 




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux