> -----Original Message----- > From: Andrew Lunn <andrew@xxxxxxx> > Sent: 02 December 2020 20:28 > To: Yash Shah <yash.shah@xxxxxxxxxxxx> > Cc: linux-spi@xxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx; linux- > pwm@xxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-riscv@xxxxxxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-gpio@xxxxxxxxxxxxxxx; > broonie@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; aou@xxxxxxxxxxxxxxxxx; > lee.jones@xxxxxxxxxx; u.kleine-koenig@xxxxxxxxxxxxxx; > thierry.reding@xxxxxxxxx; peter@xxxxxxxxxxxxx; Paul Walmsley ( Sifive) > <paul.walmsley@xxxxxxxxxx>; palmer@xxxxxxxxxxx; robh+dt@xxxxxxxxxx; > bgolaszewski@xxxxxxxxxxxx; linus.walleij@xxxxxxxxxx; Sachin Ghadi > <sachin.ghadi@xxxxxxxxxxxx> > Subject: Re: [PATCH 1/4] dt-bindings: riscv: Update DT binding docs to > support SiFive FU740 SoC > > [External Email] Do not click links or attachments unless you recognize the > sender and know the content is safe > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > index 6b25a80..1966b2c 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > +++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > @@ -3,9 +3,11 @@ Device tree configuration for i2c-ocores Required > > properties: > > - compatible : "opencores,i2c-ocores" > > "aeroflexgaisler,i2cmst" > > - "sifive,fu540-c000-i2c", "sifive,i2c0" > > + "sifive,<chip>-i2c", "sifive,i2c0" > > Please make this a full list. At some point, this file will get turned into yaml, at > which point substitution like this will need expanding. It is better to do that > now. Ok sure, will do that in patch v2. - Yash > > Andrew
