On Wed, 2 Dec 2020, at 19:11, Troy Lee wrote: > Hi Joel, > > Thanks for the suggestion, I'll fix the review and create an new patch > against > latest Linux branch. Those exported function will be referenced in > other driver yet > to be upstream, so should I move those exported functions out of this > patch? > Yes, let's leave the exports out of this patch, and add them in when you send the patch that depends on them. Andrew